KyleSchoonover commented on code in PR #1605:
URL: https://github.com/apache/avro/pull/1605#discussion_r844415984
##########
lang/csharp/src/apache/test/AvroGen/AvroGenHelper.cs:
##########
@@ -93,20 +93,21 @@ public static Assembly
CompileCSharpFilesIntoLibrary(IEnumerable<string> sourceF
{
typeof(object).Assembly.Location,
typeof(Schema).Assembly.Location,
+
typeof(System.CodeDom.Compiler.GeneratedCodeAttribute).Assembly.Location,
Path.Combine(assemblyPath, "System.Runtime.dll"),
Path.Combine(assemblyPath, "netstandard.dll")
};
// Create compiler
CSharpCompilation compilation = CSharpCompilation
- .Create(assemblyName)
- .WithOptions(new
CSharpCompilationOptions(OutputKind.DynamicallyLinkedLibrary))
- .AddReferences(assemblies.Select(path =>
MetadataReference.CreateFromFile(path)))
- .AddSyntaxTrees(sourceFiles.Select(sourceFile =>
- {
- string sourceText =
System.IO.File.ReadAllText(sourceFile);
- return CSharpSyntaxTree.ParseText(sourceText);
- }));
+ .Create(assemblyName)
Review Comment:
Sorry, I've been busy. Easy fix. For some reason I thought we were talking
about tabbing somewhere else. Yeah, VS won't change that, won't revert it back
either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
