martin-g commented on code in PR #1636:
URL: https://github.com/apache/avro/pull/1636#discussion_r846868613
##########
lang/rust/avro/src/schema.rs:
##########
@@ -503,12 +503,12 @@ pub struct UnionSchema {
// schema index given a value.
// **NOTE** that this approach does not work for named types, and will
have to be modified
// to support that. A simple solution is to also keep a mapping of the
names used.
- variant_index: HashMap<SchemaKind, usize>,
+ variant_index: BTreeMap<SchemaKind, usize>,
Review Comment:
I've changed the type of the map because otherwise it would be harder to
assert the logged error message when UnionSchema validation fails. HashMap's
Display impl prints the entries in random order every time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
