ashley-taylor commented on PR #1680:
URL: https://github.com/apache/avro/pull/1680#issuecomment-1136914683

   @martin-g I noticed a bug in how I had conditionally included the java17 
module with a profile.
   The version of the java17 module would not increment automatically when 
performing a release, causing a manual headache.
   
   I changed it always to be included but have the compile and test plugins 
disabled so that it won't complain about the version of java.
   Annoyingly I can't put any logic in the maven properties, so the property to 
enable it has to be named backwards `disableJava17`.
   This way, the module will be included for lining and release purposes but 
not actually run the code unless configured to set the flag.
   Changed the build.sh script to have a new option to run in java17 mode and 
add an expression to execute one of the two test steps conditionally.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to