ashley-taylor commented on code in PR #1680:
URL: https://github.com/apache/avro/pull/1680#discussion_r883228655
##########
lang/java/build.sh:
##########
@@ -35,6 +35,11 @@ main() {
# Test the modules that depend on hadoop using Hadoop 2
mvn -B test -Phadoop2
;;
+ testJava17)
+ mvn -DdisableJava17=false -B test
+ # Test the modules that depend on hadoop using Hadoop 2
+ mvn -B test -Phadoop2
Review Comment:
Happy to make that change. Just want to put rationale before doing that.
Might change your mind
With the change to make the module included by default but skip the
compile/tests.
running `mvn -DdisableJava17=false -B test` will run all the tests in every
module. Can add more `mvn` args to try and narrow the rerun down to only what
is needed. But figured in the main test run for java17+ enable the module
preventing the need to redo all the other work. This way it only adds a few
seconds to the build. As opposed to redoing the step that takes minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
