martin-g commented on code in PR #735:
URL: https://github.com/apache/avro/pull/735#discussion_r908148814
##########
lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java:
##########
@@ -927,6 +927,32 @@ public void testAdditionalToolsAreInjectedIntoTemplate()
throws Exception {
}
@Test
+ public void testCamelize() {
+ assertEquals("snakeCase", SpecificCompiler.camelize("snake_case", false));
+ assertEquals("constantCase", SpecificCompiler.camelize("CONSTANT_CASE",
false));
+ assertEquals("mixedSnake", SpecificCompiler.camelize("Mixed_Snake",
false));
+ assertEquals("snakeUuid", SpecificCompiler.camelize("snake_UUID", false));
+ assertEquals("lower", SpecificCompiler.camelize("lower", false));
+ assertEquals("capitalized", SpecificCompiler.camelize("Capitalized",
false));
+ assertEquals("caps", SpecificCompiler.camelize("CAPS", false));
+ assertEquals("camelCased", SpecificCompiler.camelize("camelCased", false));
+ assertEquals("camelCased", SpecificCompiler.camelize("CamelCased", false));
+ assertEquals("someUUID", SpecificCompiler.camelize("someUUID", false));
+ assertEquals("uuidFirst", SpecificCompiler.camelize("UUIDFirst", false));
+
+ assertEquals("SnakeCase", SpecificCompiler.camelize("snake_case", true));
+ assertEquals("ConstantCase", SpecificCompiler.camelize("CONSTANT_CASE",
true));
+ assertEquals("MixedSnake", SpecificCompiler.camelize("Mixed_Snake", true));
+ assertEquals("SnakeUuid", SpecificCompiler.camelize("snake_UUID", true));
+ assertEquals("Lower", SpecificCompiler.camelize("lower", true));
+ assertEquals("Capitalized", SpecificCompiler.camelize("Capitalized",
true));
+ assertEquals("CAPS", SpecificCompiler.camelize("CAPS", true));
Review Comment:
Is this intentional ?
At
https://github.com/apache/avro/pull/735/files#diff-bdda25ef6cc04f1ca556df625d9d4ecdd65951cfcd8b4e38da5916765bff75dbR946
`UUID` has been transformed to `Uuid` but here `CAPS` remains as `CAPS`. I'd
expect `Caps` instead.
##########
lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java:
##########
@@ -927,6 +927,32 @@ public void testAdditionalToolsAreInjectedIntoTemplate()
throws Exception {
}
@Test
+ public void testCamelize() {
+ assertEquals("snakeCase", SpecificCompiler.camelize("snake_case", false));
+ assertEquals("constantCase", SpecificCompiler.camelize("CONSTANT_CASE",
false));
+ assertEquals("mixedSnake", SpecificCompiler.camelize("Mixed_Snake",
false));
+ assertEquals("snakeUuid", SpecificCompiler.camelize("snake_UUID", false));
+ assertEquals("lower", SpecificCompiler.camelize("lower", false));
+ assertEquals("capitalized", SpecificCompiler.camelize("Capitalized",
false));
+ assertEquals("caps", SpecificCompiler.camelize("CAPS", false));
+ assertEquals("camelCased", SpecificCompiler.camelize("camelCased", false));
+ assertEquals("camelCased", SpecificCompiler.camelize("CamelCased", false));
+ assertEquals("someUUID", SpecificCompiler.camelize("someUUID", false));
+ assertEquals("uuidFirst", SpecificCompiler.camelize("UUIDFirst", false));
+
+ assertEquals("SnakeCase", SpecificCompiler.camelize("snake_case", true));
+ assertEquals("ConstantCase", SpecificCompiler.camelize("CONSTANT_CASE",
true));
+ assertEquals("MixedSnake", SpecificCompiler.camelize("Mixed_Snake", true));
+ assertEquals("SnakeUuid", SpecificCompiler.camelize("snake_UUID", true));
+ assertEquals("Lower", SpecificCompiler.camelize("lower", true));
+ assertEquals("Capitalized", SpecificCompiler.camelize("Capitalized",
true));
+ assertEquals("CAPS", SpecificCompiler.camelize("CAPS", true));
+ assertEquals("CamelCased", SpecificCompiler.camelize("camelCased", true));
+ assertEquals("CamelCased", SpecificCompiler.camelize("CamelCased", true));
+ assertEquals("SomeUUID", SpecificCompiler.camelize("someUUID", true));
Review Comment:
Same comment as form `CAPS` above.
##########
lang/java/compiler/src/test/java/org/apache/avro/compiler/specific/TestSpecificCompiler.java:
##########
@@ -927,6 +927,32 @@ public void testAdditionalToolsAreInjectedIntoTemplate()
throws Exception {
}
@Test
+ public void testCamelize() {
+ assertEquals("snakeCase", SpecificCompiler.camelize("snake_case", false));
+ assertEquals("constantCase", SpecificCompiler.camelize("CONSTANT_CASE",
false));
+ assertEquals("mixedSnake", SpecificCompiler.camelize("Mixed_Snake",
false));
+ assertEquals("snakeUuid", SpecificCompiler.camelize("snake_UUID", false));
+ assertEquals("lower", SpecificCompiler.camelize("lower", false));
+ assertEquals("capitalized", SpecificCompiler.camelize("Capitalized",
false));
+ assertEquals("caps", SpecificCompiler.camelize("CAPS", false));
+ assertEquals("camelCased", SpecificCompiler.camelize("camelCased", false));
+ assertEquals("camelCased", SpecificCompiler.camelize("CamelCased", false));
+ assertEquals("someUUID", SpecificCompiler.camelize("someUUID", false));
+ assertEquals("uuidFirst", SpecificCompiler.camelize("UUIDFirst", false));
+
+ assertEquals("SnakeCase", SpecificCompiler.camelize("snake_case", true));
+ assertEquals("ConstantCase", SpecificCompiler.camelize("CONSTANT_CASE",
true));
+ assertEquals("MixedSnake", SpecificCompiler.camelize("Mixed_Snake", true));
+ assertEquals("SnakeUuid", SpecificCompiler.camelize("snake_UUID", true));
+ assertEquals("Lower", SpecificCompiler.camelize("lower", true));
+ assertEquals("Capitalized", SpecificCompiler.camelize("Capitalized",
true));
+ assertEquals("CAPS", SpecificCompiler.camelize("CAPS", true));
+ assertEquals("CamelCased", SpecificCompiler.camelize("camelCased", true));
+ assertEquals("CamelCased", SpecificCompiler.camelize("CamelCased", true));
+ assertEquals("SomeUUID", SpecificCompiler.camelize("someUUID", true));
+ assertEquals("UUIDFirst", SpecificCompiler.camelize("UUIDFirst", true));
Review Comment:
Same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
