KalleOlaviNiemitalo commented on code in PR #1718:
URL: https://github.com/apache/avro/pull/1718#discussion_r910030936
##########
lang/csharp/src/apache/main/Reflect/DotnetProperty.cs:
##########
@@ -74,34 +75,38 @@ private bool IsPropertyCompatible(Avro.Schema.Type
schemaTag)
return propType == typeof(byte[]);
case Avro.Schema.Type.Error:
return propType.IsClass;
+ case Avro.Schema.Type.Logical:
+ var logicalSchema = (LogicalSchema)schema;
+ var type = logicalSchema.LogicalType.GetCSharpType(false);
+ return type == propType;
}
return false;
}
- public DotnetProperty(PropertyInfo property, Avro.Schema.Type
schemaTag, IAvroFieldConverter converter, ClassCache cache)
+ public DotnetProperty(PropertyInfo property, Avro.Schema schema,
IAvroFieldConverter converter, ClassCache cache)
Review Comment:
This does not break public API because DotnetProperty is an internal class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
