kojiromike commented on code in PR #1756:
URL: https://github.com/apache/avro/pull/1756#discussion_r925859992
##########
lang/py/avro/constants.py:
##########
@@ -57,3 +56,8 @@
)
VALID_TYPES = PRIMITIVE_TYPES + NAMED_TYPES + ("array", "map", "union",
"request", "error_union")
+
+INT_MIN_VALUE = -(1 << 31)
+INT_MAX_VALUE = (1 << 31) - 1
+LONG_MIN_VALUE = -(1 << 63)
+LONG_MAX_VALUE = (1 << 63) - 1
Review Comment:
I am fairly ambivalent about this change, because we don't appear to use
these particular constants in more than one module. They may as well be
"private". However, if it's useful externally for some reason, then I'm not
against it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
