timtebeek commented on PR #1769: URL: https://github.com/apache/avro/pull/1769#issuecomment-1192280820
Surprised about the specific failures you mentioned; would you mind reporting those to [rewrite-testing-frameworks](https://github.com/openrewrite/rewrite-testing-frameworks/issues/)? There's already a [recipe for the parameterized tests migration](https://github.com/openrewrite/rewrite-testing-frameworks/blob/main/src/main/java/org/openrewrite/java/testing/junit5/ParameterizedRunnerToParameterized.java#L54), so I'm surprised it's failing. The Arrays.equals might be inadvertently picked up as part of [`assertTrue(a.equals(b))` migration](https://github.com/openrewrite/rewrite-testing-frameworks/blob/main/src/main/java/org/openrewrite/java/testing/cleanup/AssertTrueEqualsToAssertEquals.java#L35). For now it could be a good starting point indeed; I'd suggest running the automated migration; then revert specific files with failures, and pushing the result as a separate merge request. Any left over migrations after that can then be tackled (and reviewed) separately. That way there's no (strong) need to review the automated migration changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
