martin-g commented on code in PR #1819: URL: https://github.com/apache/avro/pull/1819#discussion_r943168006
########## lang/csharp/src/apache/main/Reflect/EnumCache.cs: ########## @@ -1,57 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * https://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -using System; -using System.Collections.Concurrent; -using Avro; - -namespace Avro.Reflect -{ - /// <summary> - /// Cache of enum types. Cache key is the schema fullname. - /// </summary> - public static class EnumCache Review Comment: Is it possible to keep the class for a while as deprecated ? ########## lang/csharp/src/apache/main/Reflect/Converter/DateTimeOffsetToLongConverter.cs: ########## @@ -17,8 +17,9 @@ */ using System; +using Avro.Reflect.Interface; -namespace Avro.Reflect +namespace Avro.Reflect.Conver Review Comment: missing `er` ?! ########## lang/csharp/src/apache/main/Reflect/Reflection/DotnetClass.cs: ########## @@ -20,8 +20,9 @@ using System.Reflection; using System.Collections.Concurrent; using Avro; +using Avro.Reflect.Interface; -namespace Avro.Reflect +namespace Avro.Reflect.Reflection Review Comment: Why there are two `reflect***` packages/namespaces here ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
