KhrystynaPopadyuk commented on PR #1819: URL: https://github.com/apache/avro/pull/1819#issuecomment-1212797034
Hi @KalleOlaviNiemitalo and @martin-g , Thank you for review and feedback. I believe that at the end of day such refactoring is important and would be beneficial for both contributors (provide easier maintenance and extensibility) and end users (make it flexible, allow inject custom logic and override default behavior). There is no goal to change serialization and deserialization. All changes are around reflection. From your comments I understand that there are two main concerns: breaking changes and new dependency. I agree with @KalleOlaviNiemitalo that we can easy resolve new dependency issue - do not add DI, create new project or leave it with end user. About breaking changes. After second thought it looks like there is way to do refactoring without introducing breaking changes. The example and final state can be reviewed at https://github.com/apache/avro/pull/1823. As you can see in case if there is no breaking changes there are much more updates, that PR is massive. I do not think that it is safe to deliver such massive PR. Also it is difficult to review them. Likely we can break down it to small pieces, implement, review and deliver it one by one. First such update are created and ready for review: https://github.com/apache/avro/pull/1824. Thanks one more time for your time. Khrystyna -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
