untereiner commented on PR #1829: URL: https://github.com/apache/avro/pull/1829#issuecomment-1216692672
I am a rust beginner so I can not comment the code but for what I know it seems good. I find it very good to output serde_json::Value types instead of strings like in the c++ version. > Do we want to support serializing the custom attributes? this is what is ambiguous in the spec for me. I understand this: > where typeName is either a primitive or derived type name, as defined below. Attributes not defined in this document are permitted as metadata, but must not affect the format of serialized data as not serializing to not modify the format of serialized data -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
