KalleOlaviNiemitalo commented on code in PR #1836:
URL: https://github.com/apache/avro/pull/1836#discussion_r952780342
##########
lang/c++/impl/ValidSchema.cc:
##########
@@ -70,7 +70,7 @@ static bool validate(const NodePtr &node, SymbolMap
&symbolMap) {
node->lock();
auto leaves = node->leaves();
- for (auto i = 0; i < leaves; ++i) {
+ for (long unsigned int i = 0; i < leaves; ++i) {
Review Comment:
On 64-bit Microsoft Windows, `size_t` is 64-bit, but `long unsigned int` is
32-bit and would not be pedantically correct. In practice though, it's rather
unlikely that a node would have billions of leaves.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
