rayokota commented on PR #1833:
URL: https://github.com/apache/avro/pull/1833#issuecomment-1225084782

   > I see JsonCodecTests.cs has tests with true and false as 
JsonEncoder.IncludeNamespace; but I don't see any namespaces in the schemas 
that the tests use.
   
   The `includeNamespace` is just used to determine whether to emit the union 
label (its name is somewhat misleading).  The Java code is 
[here](https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/io/JsonEncoder.java#L297.).
  Since the C# is a straight port, the corresponding code is 
[here](https://github.com/apache/avro/blob/1133acda686fb1ff96fcbb80ca606c20e261f343/lang/csharp/src/apache/main/IO/JsonEncoder.cs#L320).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to