KalleOlaviNiemitalo commented on PR #1836: URL: https://github.com/apache/avro/pull/1836#issuecomment-1225313705
I worried that commit e632e652f3b5805609647827b9f4611e79185c6e changing the types of the local variables to size_t in might cause problems if any subsequent code tries to use negative values in those variables. I looked at the remaining parts of the modified methods and did not find any such problems, but found the `int count = --counters_.back()` assignment in Validator::countingAdvance. That seemed suspicious to me, so I searched for other uses of `counters_` and `count_` in the Validator files. I didn't even use an IDE, just a Web browser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
