KalleOlaviNiemitalo commented on code in PR #1833:
URL: https://github.com/apache/avro/pull/1833#discussion_r954557727
##########
lang/csharp/src/apache/main/IO/Encoder.cs:
##########
@@ -187,5 +187,10 @@ public interface Encoder
/// <param name="start">Position within data where the contents
start.</param>
/// <param name="len">Number of bytes to write.</param>
void WriteFixed(byte[] data, int start, int len);
+
+ /// <summary>
+ /// Flushes the encoder.
+ /// </summary>
+ void Flush();
Review Comment:
Adding a method to a public interface is a breaking change. It is OK for
this pull request to master (upcoming 1.12.0) but I think these changes should
not be backported to branch-1.11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
