martin-g commented on code in PR #1837:
URL: https://github.com/apache/avro/pull/1837#discussion_r955853650
##########
lang/rust/avro/src/schema.rs:
##########
@@ -684,10 +692,11 @@ impl UnionSchema {
Some((i, &self.schemas[i]))
} else {
// slow path (required for matching logical or named types)
- self.schemas
- .iter()
- .enumerate()
- .find(|(_, schema)| value.validate(schema))
+ self.schemas.iter().enumerate().find(|(_, schema)| {
Review Comment:
I see!
Please create a new PR for the same JIRA that makes this change and has a
unit test that shows the problem, i.e. asserts no error message is logged with
the new behavior.
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
