clesaec commented on PR #1527: URL: https://github.com/apache/avro/pull/1527#issuecomment-1233794098
PR approved (_as code for mangle is moved from SpecificCompiler to SpecificData_) with some remarks : - Mangle can transform word with point as "dummy.int.float" into "dummy.int$.float$" for example, as unmangle method only apply on last char (==> "dummy.int$.float" in our case). - Mangle only applies to reserved word, so transform "dummy$" to itself, while unmangle apply to all word (==> "dummy" in our case). - As it's a lot of static method, it may could be extract in external class. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
