RyanSkraba commented on code in PR #1842:
URL: https://github.com/apache/avro/pull/1842#discussion_r960967471
##########
lang/java/avro/src/test/java/org/apache/avro/io/TestBinaryDecoder.java:
##########
@@ -317,7 +320,7 @@ private void validateInputStreamSkips(InputStream test,
InputStream check) throw
public void testBadIntEncoding() throws IOException {
byte[] badint = new byte[5];
Arrays.fill(badint, (byte) 0xff);
- Decoder bd = factory.binaryDecoder(badint, null);
+ Decoder bd = this.newDecoder(badint);
Review Comment:
To clarify the purpose of the JIRA: this test only checks that
`binaryEncoder` correctly deals with badly encoded INTs, and it does it twice.
One of those times, `directBinaryEncoder` should be called!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
