LucasJavaudin commented on PR #1921:
URL: https://github.com/apache/avro/pull/1921#issuecomment-1286645291

   
   > Is it ? IMO the values should always be wrapped in `Value::Union`, so that 
it is possible to validate it with a Schema. The union items should be:
   
   Sorry, I meant that the test are useful and they currently pass but I agree 
that they should not pass.
   
   >     * Value::String for unit_variant
   > 
   >     * Value::Array for newtype_variant and tuple_variant
   > 
   >     * Value::Record for struct_variant
   
   For unit variant, shouldn't it be `Value::Null`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to