[
https://issues.apache.org/jira/browse/AVRO-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17676631#comment-17676631
]
Oscar Westra van Holthe - Kind commented on AVRO-3703:
------------------------------------------------------
The following code demonstrates this:
{code:java}
package opwvhk.avro;
import java.io.ByteArrayOutputStream;
import java.io.IOException;
import java.nio.charset.StandardCharsets;
import java.util.Arrays;
import org.apache.avro.Schema;
import org.apache.avro.generic.GenericData;
import org.apache.avro.generic.GenericDatumWriter;
import org.apache.avro.generic.GenericRecord;
import org.apache.avro.io.EncoderFactory;
import org.apache.avro.io.JsonEncoder;
import org.apache.avro.message.BinaryMessageDecoder;
import org.apache.avro.message.BinaryMessageEncoder;
import org.apache.avro.message.SchemaStore;
public class AvroTest {
public static void main(String[] args) throws IOException {
String avsc1 = "{\n" +
" \"type\": \"record\",\n" +
" \"name\": \"RecordSimpleName\",\n" +
" \"namespace\": \"some.namespace\",\n" +
" \"fields\": [\n" +
" {\n" +
" \"name\" : \"enumField\",\n" +
" \"type\" : {\n" +
" \"type\" : \"enum\",\n" +
" \"name\" : \"InnerEnum\",\n" +
" \"symbols\" : [ \"THE\", \"SPEC\", \"IS\",
\"A\", \"LIE\" ],\n" +
" \"doc\" : \"inherits no namespace so is
InnerEnum\"\n" +
" }\n" +
" }\n" +
" ]\n" +
"}\n";
String avsc2 = avsc1.replace("some.namespace", "something.else");
Schema schema1 = new Schema.Parser().parse(avsc1);
Schema schema2 = new Schema.Parser().parse(avsc2);
System.out.println("Schemas:");
System.out.printf("schema1.getName(): %s%nschema2.getName(): %s%n",
schema1.getName(), schema2.getName());
System.out.printf("schema1.getNamespace(): %s%nschema2.getNamespace():
%s%n", schema1.getNamespace(), schema2.getNamespace());
System.out.printf("schema1.getFullName(): %s%nschema2.getFullName():
%s%n", schema1.getFullName(), schema2.getFullName());
System.out.println();
System.out.println("Records (toString() and in Avro JSON encoding):");
GenericData model = GenericData.get();
GenericRecord record1 = (GenericRecord) model.newRecord(null, schema1);
Object enumValue1 = model.createEnum("LIE",
schema1.getField("enumField").schema());
record1.put("enumField", enumValue1);
System.out.printf("record1 = %s%n", record1);
ByteArrayOutputStream baos1 = new ByteArrayOutputStream();
JsonEncoder jsonEncoder1 = EncoderFactory.get().jsonEncoder(schema1,
baos1);
GenericDatumWriter<GenericRecord> writer1 = new
GenericDatumWriter<>(schema1, model);
writer1.write(record1, jsonEncoder1);
jsonEncoder1.flush();
System.out.printf("record1 in JSON encoding: %s%n",
baos1.toString(StandardCharsets.UTF_8));
GenericRecord record2 = (GenericRecord) model.newRecord(null, schema2);
Object enumValue2 = model.createEnum("LIE",
schema2.getField("enumField").schema());
record2.put("enumField", enumValue2);
System.out.printf("record2 = %s%n", record1);
ByteArrayOutputStream baos2 = new ByteArrayOutputStream();
JsonEncoder jsonEncoder2 = EncoderFactory.get().jsonEncoder(schema2,
baos2);
GenericDatumWriter<GenericRecord> writer2 = new
GenericDatumWriter<>(schema2, model);
writer2.write(record2, jsonEncoder2);
jsonEncoder2.flush();
System.out.printf("record2 in JSON encoding: %s%n",
baos1.toString(StandardCharsets.UTF_8));
System.out.println();
System.out.println("Now using binary 'singlemessage encoding':");
// SME consists of 2 fixed bytes, 8 bytes schema fingerprint, plus
binary content
// The content in this case is 1 byte (the enum index, zigzag encoded)
// As both enums define the same symbols in the same order, that's both
4 (0-based); encoded as 0x08
BinaryMessageEncoder<GenericRecord> encoder1 = new
BinaryMessageEncoder<>(model, schema1);
byte[] bytes1 = encoder1.encode(record1).array();
System.out.printf("Record1 in binary SME: %s%n",
Arrays.toString(bytes1));
BinaryMessageEncoder<GenericRecord> encoder2 = new
BinaryMessageEncoder<>(model, schema2);
byte[] bytes2 = encoder2.encode(record2).array();
System.out.printf("Record2 in binary SME: %s%n",
Arrays.toString(bytes2));
SchemaStore.Cache schemaStore = new SchemaStore.Cache();
schemaStore.addSchema(schema1);
BinaryMessageDecoder<GenericRecord> decoder = new
BinaryMessageDecoder<>(model, schema2, schemaStore);
GenericRecord decoded = decoder.decode(bytes1);
System.out.printf("record1 decoded into schema2: %s%n", decoded);
}
}
{code}
> avro 1.11.1 stopped validating namespace changes on deserialization
> -------------------------------------------------------------------
>
> Key: AVRO-3703
> URL: https://issues.apache.org/jira/browse/AVRO-3703
> Project: Apache Avro
> Issue Type: Bug
> Components: java
> Affects Versions: 1.11.1
> Reporter: Radai Rosenblatt
> Priority: Major
>
> the following test passes on 1.11.0 but fails on 1.11.1:
> {code}
> @Test(expected = AvroTypeException.class)
> public void testFullnameValidation() throws Exception {
> String avsc1 =
> "{\n"
> + " \"type\": \"record\",\n"
> + " \"name\": \"RecordSimpleName\",\n"
> + " \"namespace\": \"some.namespace\",\n"
> + " \"fields\": [\n"
> + " {\n"
> + " \"name\" : \"enumField\",\n"
> + " \"type\" : {\n"
> + " \"type\" : \"enum\",\n"
> + " \"name\" : \"InnerEnum\",\n"
> + " \"symbols\" : [ \"THE\", \"SPEC\", \"IS\", \"A\", \"LIE\"
> ],\n"
> + " \"doc\" : \"inherits no namespace so is InnerEnum\"\n"
> + " }\n"
> + " }\n"
> + " ]\n"
> + "}\n";
> String avsc2 = avsc1.replace("some.namespace", "something.else");
> Schema schema1 = Schema.parse(avsc1);
> Schema schema2 = Schema.parse(avsc2);
> Assert.assertEquals(schema1.getName(), schema2.getName());
> Assert.assertNotEquals(schema1.getNamespace(), schema2.getNamespace());
> Assert.assertNotEquals(schema1.getFullName(), schema2.getFullName());
> GenericDatumReader<IndexedRecord> reader = new
> GenericDatumReader<>(schema1, schema2);
> JsonDecoder decoder = DecoderFactory.get().jsonDecoder(schema1,
> "{\"enumField\": \"LIE\"}");
> IndexedRecord deserialized = reader.read(null, decoder);
> Assert.fail("deserialization should have failed over namespace mismatch");
> }
> {code}
> looks like avro 1.11.1 disregards namespace/fullnames during deserialization?
> (this was the behaviour under avro 1.4)
> 1.11.0 produces the expected failure:
> {code}
> org.apache.avro.AvroTypeException: Found some.namespace.InnerEnum, expecting
> something.else.InnerEnum
> at
> org.apache.avro.io.ResolvingDecoder.doAction(ResolvingDecoder.java:308)
> at org.apache.avro.io.parsing.Parser.advance(Parser.java:86)
> at
> org.apache.avro.io.ResolvingDecoder.readEnum(ResolvingDecoder.java:259)
> at
> org.apache.avro.generic.GenericDatumReader.readEnum(GenericDatumReader.java:268)
> at
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:182)
> at
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:161)
> at
> org.apache.avro.generic.GenericDatumReader.readField(GenericDatumReader.java:260)
> at
> org.apache.avro.generic.GenericDatumReader.readRecord(GenericDatumReader.java:248)
> at
> org.apache.avro.generic.GenericDatumReader.readWithoutConversion(GenericDatumReader.java:180)
> at
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:161)
> at
> org.apache.avro.generic.GenericDatumReader.read(GenericDatumReader.java:154)
> at
> org.apache.avro.generic.TestFullnameEnforcement.testFullnameValidation(TestFullnameEnforcement.java:59)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
> at
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater$1.execute(IdeaTestRunner.java:38)
> at
> com.intellij.rt.execution.junit.TestsRepeater.repeat(TestsRepeater.java:11)
> at
> com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:35)
> at
> com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
> at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
