clesaec commented on PR #2053: URL: https://github.com/apache/avro/pull/2053#issuecomment-1385418428
NameValidator has no direct link with Schema nor SchemaParser; so it could be easily embeded in SchemaParser or put in a separate Java file with your PR (i didn't figure out yet what would be the best). And i agree with you, even if Schema.java is divided into several small independant pieces (classes), i also would prefer to see SchemaParser in a separate file (and mostly put [Schema.parse(JsonNodes, Names) method outside](https://github.com/apache/avro/blob/master/lang/java/avro/src/main/java/org/apache/avro/Schema.java#L1672) of Schema class). I also made this small [PR](https://github.com/apache/avro/pull/1768) on schema parsing that allow to load recursive protocol like ```json {"name": "User", "type": "record", "fields": [{"name": "current_status", "type": "Status"}]} {"name": "Status", "type": "record", "fields": [{"name": "author", "type": "User"}]} ``` I would adapt it if yours is merge before :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
