woile commented on code in PR #2087:
URL: https://github.com/apache/avro/pull/2087#discussion_r1101044193
##########
lang/rust/avro/src/schema.rs:
##########
@@ -611,8 +611,8 @@ impl RecordField {
aliases
.iter()
.flat_map(|alias| alias.as_str())
- .map(|alias| Alias::new(alias).expect("Alias is not
valid"))
- .collect::<Vec<Alias>>()
+ .map(|alias| alias.to_string())
+ .collect::<Vec<String>>()
Review Comment:
Where did you find the information about Aliases not requiring namespaces
for `RecordField`? I was using the same `alias parser` to parse an `Enum` for
example, but they now have different signature, it's not really a problem, but
in the spec the text is the same for `Enum` and for `RecordField`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
