KalleOlaviNiemitalo commented on code in PR #2101: URL: https://github.com/apache/avro/pull/2101#discussion_r1108280484
########## lang/csharp/src/apache/msbuild/Apache.Avro.MSBuild.props: ########## @@ -0,0 +1,19 @@ +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + https://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<Project> + <UsingTask TaskName="Avro.msbuild.AvroGenTask" AssemblyFile="$(MSBuildThisFileDirectory)..\tasks\$(TargetFramework)\Avro.msbuild.dll" /> Review Comment: Re using `$(MSBuildVersion)`, the idea is that although MSBuild provides neither a built-in property nor a property function for getting the version of .NET on which MSBuild is running, each version of MSBuild on .NET requires some minimum version of .NET, so if `$(MSBuildVersion)` shows you have that version of MSBuild, then you can assume it can load assemblies built for the corresponding version of .NET. But I don't really see what advantage this would have over always using netstandard2.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
