KalleOlaviNiemitalo commented on code in PR #1966: URL: https://github.com/apache/avro/pull/1966#discussion_r1109911894
########## lang/csharp/README.md: ########## @@ -63,7 +63,12 @@ Example: </ItemGroup> <Target Name="AvroGenerate" BeforeTargets="CoreCompile"> - <AvroGenTask SchemaFiles="@(SchemaFiles)" OutDir="generated" /> + <AvroGenTask SchemaFiles="@(SchemaFiles)" OutDir="generated" > + <!-- bind generated files task output --> + <Output ItemName="GeneratedCodeFiles" TaskParameter="GeneratedFiles" /> + </AvroGenTask> + <!-- displays generated files in build logs --> + <Message Text="Generated: %(GeneratedCodeFiles.Identity)" Importance="normal" /> Review Comment: When you use `OutDir="generated"`, the resulting `%(GeneratedCodeFiles.Identity)` will be a relative path that starts with "generated" rather than a full path, right? If so, then that's fine, but is it what you intended? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
