zcsizmadia commented on code in PR #1966: URL: https://github.com/apache/avro/pull/1966#discussion_r1109932456
########## lang/csharp/README.md: ########## @@ -63,7 +63,12 @@ Example: </ItemGroup> <Target Name="AvroGenerate" BeforeTargets="CoreCompile"> - <AvroGenTask SchemaFiles="@(SchemaFiles)" OutDir="generated" /> + <AvroGenTask SchemaFiles="@(SchemaFiles)" OutDir="generated" > + <!-- bind generated files task output --> + <Output ItemName="GeneratedCodeFiles" TaskParameter="GeneratedFiles" /> + </AvroGenTask> + <!-- displays generated files in build logs --> + <Message Text="Generated: %(GeneratedCodeFiles.Identity)" Importance="normal" /> Review Comment: The generated files are always a realtive path to the OutDir, and the path starting with OutDir. Havent tried it, but `WriteTypes` just combines OutDir with the extra path (namespaces). There is no conversion to absolute path, so that relative path will be returned in the `GeneratedFiles` list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
