frankgrimes97 commented on code in PR #2137:
URL: https://github.com/apache/avro/pull/2137#discussion_r1132610925
##########
lang/java/avro/src/test/java/org/apache/avro/generic/TestGenericData.java:
##########
@@ -198,6 +198,25 @@ public void testMapValuesEquals() {
assertEquals(r1, r0);
}
+ @Test
+ public void testArrayValuesEqualsStringAndUtf8Compatibility() {
+ Schema arrayElementSchema = new Schema.Parser().parse("{\"type\":
\"string\"}");
Review Comment:
Not 100% if this is what you mean, but looking at it again I do see that the
code can be simplified as:
```
Field myMapField = new Field("my_map",
Schema.createMap(Schema.create(Schema.Type.STRING)), null, null);
Schema schema = Schema.createRecord("my_record", "doc", "mytest", false);
```
and
```
Field myArrayField = new Field("my_array",
Schema.createArray(Schema.create(Schema.Type.STRING)), null, null);
Schema schema = Schema.createRecord("my_record", "doc", "mytest", false);
```
I can force-push that if you'd prefer... or am I missing something else?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
