[GitHub] [avro] alexrosenfeld10 commented on a diff in pull request #2215: AVRO-3756: [csharp] Add a method to return types instead of writing them to disk

Tue, 13 Jun 2023 11:44:36 -0700 


alexrosenfeld10 commented on code in PR #2215:
URL: https://github.com/apache/avro/pull/2215#discussion_r1228551968


##########
lang/csharp/src/apache/main/CodeGen/CodeGen.cs:
##########
@@ -1136,6 +1136,48 @@
             }
         }
 
+        /// <summary>
+        /// Gets names and generated code of the schema(s) types
+        /// </summary>
+        /// <returns></returns>
+        public virtual IDictionary<string, string> GetTypes()
+        {
+            var cscp = new CSharpCodeProvider();

Review Comment:
   @zcsizmadia I looked at this, it requires changing the `LangVersion` for the 
project.
   ![Screenshot 2023-06-13 at 2 38 22 
PM](https://github.com/apache/avro/assets/12940966/857f9f5e-206e-42e7-b4c5-bffe5ca1c76e)
   
   Happy to make these changes, but it seems out of scope for this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to