[ 
https://issues.apache.org/jira/browse/AVRO-3473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17733166#comment-17733166
 ] 

ASF subversion and git services commented on AVRO-3473:
-------------------------------------------------------

Commit 54f5d08b7df43866d499526ceefeba153de20a6f in avro's branch 
refs/heads/branch-1.11 from Oscar Westra van Holthe - Kind
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=54f5d08b7 ]

AVRO-3473: ServiceLoader for Conversion (#1624)

* AVRO-3473: ServiceLoader for Conversion

Automatically register Conversion classes using the Java 6 service
loader upon startup. This works for any Conversion that does not need
constructor parameters.

* AVRO-3473: ServiceLoader for Conversion

Improved variable name.

* AVRO-3473: Spotless

* Apply suggestions from code review

Co-authored-by: Ryan Skraba <[email protected]>

* AVRO-3473: Removed newline to trigger build

* AVRO-3473: Add missing import

No idea when that got dropped...

* AVRO-3473: Removed unused import

* AVRO-3473: Fix rebase errors

* Fix static imports

---------

Co-authored-by: Ryan Skraba <[email protected]>


> Automatically register Conversion<T> classes
> --------------------------------------------
>
>                 Key: AVRO-3473
>                 URL: https://issues.apache.org/jira/browse/AVRO-3473
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: java, logical types
>            Reporter: Oscar Westra van Holthe - Kind
>            Assignee: Oscar Westra van Holthe - Kind
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.11.2
>
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Manually registering a {{Conversion<T>}} is cumbersome, but necessary if 
> creating the factory requires constructor parameters.
> For most cases though, a {{Conversion<T>}} gets all the information it needs 
> from the schema. This makes it a good candidate for a SPI (using the Java 6 
> {{ServiceLoader}} class).
> This is the addendum to AVRO-3441, which does the same thing for 
> {{{}LogicalTypeFactory{}}}.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to