opwvhk commented on code in PR #2282:
URL: https://github.com/apache/avro/pull/2282#discussion_r1232191466
##########
lang/java/avro/src/main/java/org/apache/avro/Conversions.java:
##########
@@ -146,6 +154,65 @@ private static BigDecimal validate(final
LogicalTypes.Decimal decimal, BigDecima
}
}
+ public static class BigDecimalConversion extends Conversion<BigDecimal> {
+
+ @Override
+ public Class<BigDecimal> getConvertedType() {
+ return BigDecimal.class;
+ }
+
+ @Override
+ public String getLogicalTypeName() {
+ return "bigdecimal";
+ }
+
+ @Override
+ public BigDecimal fromBytes(final ByteBuffer value, final Schema schema,
final LogicalType type) {
+ BinaryDecoder decoder =
DecoderFactory.get().binaryDecoder(value.array(), null);
+
+ try {
+ BigInteger bg = null;
+ ByteBuffer buffer = decoder.readBytes(null);
+ byte[] array = buffer.array();
+ if (array != null && array.length > 0) {
+ bg = new BigInteger(array);
+ }
+
+ int scale = decoder.readInt();
+ return new BigDecimal(bg, scale);
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ }
+
+ @Override
+ public ByteBuffer toBytes(final BigDecimal value, final Schema schema,
final LogicalType type) {
+ try {
+ ByteArrayOutputStream out = new ByteArrayOutputStream();
+ BinaryEncoder encoder = EncoderFactory.get().binaryEncoder(out, null);
+
+ BigInteger unscaledValue = value.unscaledValue();
+ if (unscaledValue != null) {
+ encoder.writeBytes(unscaledValue.toByteArray());
+ } else {
+ encoder.writeBytes(new byte[] {});
+ }
+ encoder.writeInt(value.scale());
+ encoder.flush();
+ return ByteBuffer.wrap(out.toByteArray());
+
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
Review Comment:
Note that switching the position of the scale and value also saves a byte
(or more) in the final result: the converted value no longer has a byte array
length indicator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
