dervan commented on code in PR #2334:
URL: https://github.com/apache/avro/pull/2334#discussion_r1262395378
##########
lang/java/maven-plugin/src/main/java/org/apache/avro/mojo/AbstractAvroMojo.java:
##########
@@ -213,7 +213,9 @@ public void execute() throws MojoExecutionException {
if (hasImports) {
for (String importedFile : imports) {
File file = new File(importedFile);
- if (file.isDirectory()) {
+ if (!file.exists()) {
Review Comment:
I was considering that, but it seems that if _imports_ field is non-null,
then we may be sure that during the execution we will check every imported file
in line 216. Indeed, even if _getIncludedFiles_ would execute first, the
nonexistent file will be found by line 216 in a next iteration. Do you think
it's anyway beneficial to check it anyway in _getIncludedFiles_?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
