kojiromike commented on code in PR #2319:
URL: https://github.com/apache/avro/pull/2319#discussion_r1264272206
##########
lang/py/avro/schema.py:
##########
@@ -873,20 +873,37 @@ def __init__(
if schema_type == "request":
Schema.__init__(self, schema_type, other_props)
else:
- NamedSchema.__init__(self, schema_type, name, namespace, names,
other_props, validate_names=validate_names)
+ NamedSchema.__init__(
+ self,
+ schema_type,
+ name,
+ namespace,
+ names,
+ other_props,
+ validate_names=validate_names,
+ )
names = names or Names(validate_names=self.validate_names)
- if schema_type == "record":
+ if (schema_type == "record") or (schema_type == "error"):
old_default = names.default_namespace
- names.default_namespace = Name(name, namespace,
names.default_namespace, validate_name=validate_names).space
+ names.default_namespace = Name(
+ name,
+ namespace,
+ names.default_namespace,
+ validate_name=validate_names,
+ ).space
# Add class members
- field_objects = RecordSchema.make_field_objects(fields, names,
validate_names=validate_names)
+ field_objects = RecordSchema.make_field_objects(
+ fields,
+ names,
+ validate_names=validate_names,
+ )
self.set_prop("fields", field_objects)
if doc is not None:
self.set_prop("doc", doc)
- if schema_type == "record":
+ if (schema_type == "record") or (schema_type == "error"):
Review Comment:
```suggestion
if schema_type in ("record", "error"):
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
