kojiromike commented on code in PR #1570:
URL: https://github.com/apache/avro/pull/1570#discussion_r1268862602
##########
lang/py/build.sh:
##########
@@ -17,13 +17,14 @@
set -e
-usage() {
- echo "Usage: $0
{clean|dist|interop-data-generate|interop-data-test|lint|test}"
- exit 1
-}
+cd "$(dirname "$0")" # If being called from another folder, cd into the
directory containing this script.
+
+# shellcheck disable=SC1091
+source ../../share/build-helper.sh "Python"
-clean() {
- git clean -xdf '*.avpr' \
+function command_clean()
Review Comment:
Please remove the `function` keyword from everywhere else instead of adding
it here. There is very little practical difference, except that we should
default to fewer characters when there is no reasonable argument for more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
