KalleOlaviNiemitalo commented on code in PR #2430:
URL: https://github.com/apache/avro/pull/2430#discussion_r1288347960
##########
lang/java/avro/src/main/java/org/apache/avro/Schema.java:
##########
@@ -1645,6 +1643,17 @@
return name;
}
+ private static String validateSpace(String space) {
+ if ("".equals(space) || space == null) {
Review Comment:
I expect the `space.split("\\.")` call immediately after will be even more
inefficient.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
