KalleOlaviNiemitalo commented on PR #2430: URL: https://github.com/apache/avro/pull/2430#issuecomment-1671725282
This use of the dollar sign is apparently defined in Java language specification ยง13.1 (The Form of a Binary), so all Java compilers should generate the same _binary name_ `Test$M`. However, for local or anonymous classes, the JLS requires "a non-empty sequence of digits", and I think different compilers could choose different digits. Application developers then should not use such classes for Avro data, as it would be difficult from them to ensure that the name stays the same. I'd prefer keeping dollar signs disallowed in the Avro specification. Schemas that use dollar signs won't be fully portable to other languages, even if the Java implementation of Avro allows them. It might be useful to have a strict mode that flags them in the Java implementation too, but I don't know how that should be configured. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
