sarutak commented on code in PR #2433:
URL: https://github.com/apache/avro/pull/2433#discussion_r1289632189
##########
lang/rust/avro/src/schema.rs:
##########
@@ -1440,7 +1440,12 @@ impl Parser {
.collect::<Result<_, _>>()
})?;
+ let mut existing_fields: HashSet<&String> =
HashSet::with_capacity(fields.len());
for field in &fields {
+ if existing_fields.contains(&field.name) {
+ return Err(Error::FieldNameDuplicate(field.name.clone()));
+ }
+ existing_fields.insert(&field.name);
Review Comment:
Yes, we can use `lookup`. I've fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
