KalleOlaviNiemitalo commented on PR #2439: URL: https://github.com/apache/avro/pull/2439#issuecomment-1680627634
@zcsizmadia, I agree the IDispose implementation on BinaryEncoder and BinaryDecoder can be omitted from this PR. Especially as this PR does not make DataFileReader\<T>.Dispose() call BinaryDecoder.Dispose on its `_decoder` or `_datumDecoder`. If DataFileReader\<T> is changed to dispose of streams other than its main `_stream`, and it is convenient to do that as part of BinaryDecoder disposal, then one can also define `private class DisposingBinaryDecoder : BinaryDecoder, IDisposable` within DataFileReader\<T> and it won't be a change in public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
