zcsizmadia commented on PR #2439: URL: https://github.com/apache/avro/pull/2439#issuecomment-1680651039
@CamilAbraham Just a little bit reasoning behind this is if the user has CA2000 (or IDE0067) warning enabled in their code, after making BinaryEncoder or Decoder IDisposable they will get compiler/analyzer warning(s). Just fyi the avro code analyzer config we use, disables CA2000 (https://github.com/apache/avro/blob/master/lang/csharp/CodeAnalysis.src.globalconfig#L413-L414) https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca2000 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
