RyanSkraba commented on code in PR #2506:
URL: https://github.com/apache/avro/pull/2506#discussion_r1332015373


##########
lang/java/avro/src/test/java/org/apache/avro/io/TestEncoders.java:
##########
@@ -262,6 +262,7 @@ void arrayBackedByteBuffer() throws IOException {
   @Test
   void mappedByteBuffer() throws IOException {
     Path file = Paths.get(DIR.getPath() + "testMappedByteBuffer.avro");
+    file.toFile().deleteOnExit();

Review Comment:
   ```suggestion
       Path file = DIR.toPath().resolve( "testMappedByteBuffer.avro");
   ```
   For example: here we have a `@TempDir` already present, and cleaned up 
automatically in the test case -- we just accidentally forgot the path 
separator so the file was _outside_! 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to