mystic-lama commented on code in PR #2506:
URL: https://github.com/apache/avro/pull/2506#discussion_r1335215330
##########
lang/java/avro/src/test/java/org/apache/avro/TestDataFileReader.java:
##########
@@ -38,9 +38,12 @@
import org.apache.avro.generic.GenericDatumReader;
import org.apache.avro.generic.GenericDatumWriter;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
@SuppressWarnings("restriction")
public class TestDataFileReader {
+ @TempDir
+ public Path DATA_DIR;
Review Comment:
Can we relook at the variable name once please? This format used is for
constants, giving an impression that it is static final.
##########
lang/java/avro/src/test/java/org/apache/avro/TestDataFileReader.java:
##########
@@ -38,9 +38,12 @@
import org.apache.avro.generic.GenericDatumReader;
import org.apache.avro.generic.GenericDatumWriter;
import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
@SuppressWarnings("restriction")
public class TestDataFileReader {
+ @TempDir
+ public Path DATA_DIR;
Review Comment:
Can we relook at the variable name once please? This format used is for
constants, giving an impression that it is static final. Same for similar name
in other classes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
