opwvhk commented on code in PR #2520: URL: https://github.com/apache/avro/pull/2520#discussion_r1335970947
########## lang/java/avro/src/main/java/org/apache/avro/util/TimePeriod.java: ########## @@ -0,0 +1,400 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * https://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.avro.util; + +import java.io.Serializable; +import java.time.DateTimeException; +import java.time.Duration; +import java.time.Period; +import java.time.chrono.ChronoPeriod; +import java.time.chrono.IsoChronology; +import java.time.temporal.ChronoUnit; +import java.time.temporal.Temporal; +import java.time.temporal.TemporalAmount; +import java.time.temporal.TemporalUnit; +import java.time.temporal.UnsupportedTemporalTypeException; +import java.util.ArrayList; +import java.util.List; +import java.util.Objects; + +import static java.time.temporal.ChronoUnit.DAYS; +import static java.time.temporal.ChronoUnit.MILLIS; +import static java.time.temporal.ChronoUnit.MONTHS; +import static java.util.Collections.unmodifiableList; +import static java.util.Objects.requireNonNull; + +/** + * <p> + * A temporal amount to model an {@link org.apache.avro.LogicalTypes.Duration + * Avro duration} (the logical type). + * </p> + * + * <p> + * It consists of a number of months, days and milliseconds, all modelled as an + * unsigned integer. + * </p> + * + * <p> + * Compared to {@link Period java.time.Period}, this class has a smaller range + * ('only' supporting a little less than 358 million years), and cannot support + * negative time periods. + * </p> + * + * <p> + * Compared to {@link Duration java.time.Duration}, this class has less + * precision (milliseconds compared to nanoseconds), cannot support negative + * durations, and has a much smaller range. Where {@code java.time.Duration} + * supports fixed ranges up to about 68 years, {@code TimePeriod} can only + * handle about 49 days. + * </p> + * + * <p> + * Given the time span of what we do, + * </p> + * supporting a little less than 358 million years), and cannot support negative + * time periods. + * </p> Review Comment: You're right. This paragraph should be removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
