clesaec commented on code in PR #2529:
URL: https://github.com/apache/avro/pull/2529#discussion_r1342548625


##########
lang/java/avro/src/test/java/org/apache/avro/TestSchemaBuilder.java:
##########
@@ -111,14 +112,14 @@ void objectProps() {
     assertTrue(s.getObjectProp("intProp") instanceof Integer);
     assertTrue(s.getObjectProp("longProp") instanceof Long);
     assertEquals(Long.MAX_VALUE, s.getObjectProp("longProp"));
-    assertTrue(s.getObjectProp("floatProp") instanceof Double);
+    assertTrue(s.getObjectProp("floatProp") instanceof Float);
     // float converts to double

Review Comment:
   ? Double is replaced by Float for "floatProp"; i don't understand the point 
of removing this line ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to