sarutak commented on code in PR #2538:
URL: https://github.com/apache/avro/pull/2538#discussion_r1344376019
##########
.github/workflows/test-lang-rust-ci.yml:
##########
@@ -59,19 +60,27 @@ jobs:
uses: actions/checkout@v4
- name: Cache Cargo
+ id: cache-cargo
uses: actions/cache@v3
with:
# these represent dependencies downloaded by cargo
# and thus do not depend on the OS, arch nor rust version.
path: ~/.cargo
- key: cargo-cache1-
+ key: ${{ runner.os }}-cargo-cache1-${{ matrix.target }}-${{
matrix.rust }}-${{ hashFiles('**/Cargo.lock') }}
+
Review Comment:
I didn't use `${{ matrix.target }}` and `${{ matrix.rust }}` intentionally
because many caches are generated and take up the cache capacity.
See https://github.com/apache/avro/actions/caches
Rust related cache takes up approximately 9GB while the capacity limit is
10GB.
Do you think it's cost effective for the degree of the improvement?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
