rdblue commented on code in PR #2554:
URL: https://github.com/apache/avro/pull/2554#discussion_r1360953523


##########
doc/content/en/docs/++version++/Specification/_index.md:
##########
@@ -862,6 +862,11 @@ The `timestamp-micros` logical type represents an instant 
on the global timeline
 
 A `timestamp-micros` logical type annotates an Avro `long`, where the long 
stores the number of microseconds from the unix epoch, 1 January 1970 
00:00:00.000000 UTC.
 
+### Timestamp (nanosecond precision)
+The `timestamp-nanos` logical type represents an instant on the global 
timeline, independent of a particular time zone or calendar, with a precision 
of one nanosecond. Please note that time zone information gets lost in this 
process. Upon reading a value back, we can only reconstruct the instant, but 
not the original representation. In practice, such timestamps are typically 
displayed to users in their local time zones, therefore they may be displayed 
differently depending on the execution environment.

Review Comment:
   I don't think it's accurate to say that "time zone information gets lost in 
this process" because the type is independent of a zone. I also would not refer 
to "the instant". Assuming that this logical type corresponds to `TIMESTAMP(9) 
WITHOUT TIME ZONE`, I would say that any statement should be the displayed 
value must never be modified with respect to the system time zone because it 
has no time zone.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to