iemejia commented on code in PR #2525:
URL: https://github.com/apache/avro/pull/2525#discussion_r1367484021
##########
lang/java/build.sh:
##########
@@ -34,6 +34,16 @@ main() {
mvn -B test
# Test the modules that depend on hadoop using Hadoop 2
mvn -B test -Phadoop2
+ # Test external avro archetype generation
+ mvn archetype:generate \
+ -DarchetypeGroupId=org.apache.avro \
+ -DarchetypeArtifactId=avro-service-archetype \
+ -DgroupId=org.apache.avro \
Review Comment:
I did not want to do that to avoid having to update the current version on
every release (usually project maintainers tend to forget that). I digged
deeper and found that there is a way to do integration tests on maven
archetypes so it is maybe a better solution (Avro already was doing it but it
was not well configurated for modern maven standards).
https://maven.apache.org/archetype/maven-archetype-plugin/integration-test-mojo.html
I will update this in the PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
