[ 
https://issues.apache.org/jira/browse/AVRO-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780750#comment-17780750
 ] 

zejiong dong commented on AVRO-3896:
------------------------------------

Sorry, I find that there is a function to do this job 
[try_logical_type|https://github.com/apache/avro/blob/f0fd236f27a378a4fbd8b3334d04a41bd32e8169/lang/rust/avro/src/schema.rs#L1318]
 actually. But seems it isn't used in all logical types. Can we consider using 
it in all types? I sent a PR to do this. 

> [Rust] support read schema with custom logical type
> ---------------------------------------------------
>
>                 Key: AVRO-3896
>                 URL: https://issues.apache.org/jira/browse/AVRO-3896
>             Project: Apache Avro
>          Issue Type: Improvement
>            Reporter: zejiong dong
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I find that it can't read schema with custom logical type because it has the 
> [check|https://github.com/apache/avro/blob/807314512736c2a1c0a4203f4eb9b5d84aa021e4/lang/rust/avro/src/schema.rs#L1275]
>  to guarantee that the logical type must be supported in avro-rust.
> Can we modify the 
> [check|https://github.com/apache/avro/blob/807314512736c2a1c0a4203f4eb9b5d84aa021e4/lang/rust/avro/src/schema.rs#L1275]
>  here to support reading custom logical type:
> 1. If the logical type is supported in avro-rust, it's fine and we convert it.
> 2. If the logical type is not supported, treat it as the original type and 
> keep the "logicalType" as an attribute.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to