opwvhk commented on PR #2568: URL: https://github.com/apache/avro/pull/2568#issuecomment-1784656051
> Since #1589, we have: > > * IDLMojo - @goal idl - Generate Java classes and interfaces from AvroIDL files (.avdl) > * IDLProtocolMojo - @goal idl-protocol - The old version of IDLMojo > > `IDLMojo` looks like a generic IDL tool so I added the new actions to it. I think it would be clearer if it had a more meaningful name likes `IDL2JavaMojo` > > And the new Mojos might be: > > * `IDL2ProtocolMojo` - @goal idl-2-protocol - Generate Json protocol from Avro IDL files (.avdl) > * `IDL2SchemaMojo` - @goal idl-2-schema - Generate Json Schema from Avro IDL files (.avdl) > Are they OK? Looks good, but I'm not a fan of the `-2-` infix; it looks like a separate number. I prefer this without the dashes, but `-to-` as infix works as well. Given that #1589 hasn't been released yet, what do you think of the following: * `IDL2JavaMojo` - @goal idl2java - Generate Java classes and interfaces from AvroIDL files (.avdl) * `IDLProtocolMojo` - @goal idl-protocol - The old version of IDLMojo * `IDL2ProtocolMojo` - @goal idl2protocol - Generate Json protocol from Avro IDL files (.avdl) * `IDL2SchemaMojo` - @goal idl2schema - Generate Json Schema from Avro IDL files (.avdl) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
