marcosschroh commented on code in PR #2633:
URL: https://github.com/apache/avro/pull/2633#discussion_r1422569111
##########
lang/rust/avro/src/schema_compatibility.rs:
##########
@@ -158,17 +158,45 @@ impl Checker {
}) = readers_schema
{
for field in r_fields.iter() {
- if let Some(pos) = w_lookup.get(&field.name) {
- if let Err(err) =
- self.full_match_schemas(&w_fields[*pos].schema,
&field.schema)
- {
- return Err(CompatibilityError::FieldTypeMismatch(
- field.name.clone(),
- Box::new(err),
- ));
+ // get all field names in a vector (field.name + aliases)
+ let mut fields_names = vec![field.name.clone()];
Review Comment:
Cool!! Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
