[ 
https://issues.apache.org/jira/browse/AVRO-3889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802067#comment-17802067
 ] 

ASF subversion and git services commented on AVRO-3889:
-------------------------------------------------------

Commit 0a2323fedffb3b4e63f46fb1e1197f0a547dac4a in avro's branch 
refs/heads/branch-1.11 from Brian Cullen
[ https://gitbox.apache.org/repos/asf?p=avro.git;h=0a2323fed ]

AVRO-3889: [Java][Build] Maven IDL Generation Modification Check (#2561)

Check if the IDL source file has changed before regenerating the Java
classes to prevent unnecessary recompilation when using maven.

Co-authored-by: Brian Cullen <[email protected]>

> Maven Plugin Always Recompiles IDL Files
> ----------------------------------------
>
>                 Key: AVRO-3889
>                 URL: https://issues.apache.org/jira/browse/AVRO-3889
>             Project: Apache Avro
>          Issue Type: Bug
>          Components: build, java
>    Affects Versions: 1.12.0, 1.11.3, 1.11.4
>            Reporter: Brian Cullen
>            Priority: Minor
>              Labels: pull-request-available
>          Time Spent: 2h
>  Remaining Estimate: 0h
>
> Currently both the TestIDLProtocolMojo (in version 1.11.x) and the IDLMojo in 
> master fail to pass the source file into the compiler when calling the 
> compile to destination method. This means that the IDL files are never 
> registered as up to date and are always recompiled when the plugin is 
> executed. The knock on effect of this is that the maven compiler plugin 
> always thinks it needs to recompile the whole project which is not ideal.
> It does appear that this is a simple change to pass the source file into the 
> method so that the up to date check can be preformed. I have made the change 
> locally and to try it out. It appears to work but I don't know if I'm missing 
> something that means this won't work in some cases.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to