opwvhk commented on code in PR #2652:
URL: https://github.com/apache/avro/pull/2652#discussion_r1442745011
##########
lang/java/avro/src/main/java/org/apache/avro/Conversions.java:
##########
@@ -44,6 +44,17 @@
public class Conversions {
public static class UUIDConversion extends Conversion<UUID> {
+
+ private final boolean isBigEndian;
+
+ public UUIDConversion() {
+ this(ByteOrder.nativeOrder() == ByteOrder.BIG_ENDIAN);
Review Comment:
Given that UUIDs are 128 bit labels (source with extra references:
https://en.wikipedia.org/wiki/Universally_unique_identifier#Binary_wire_format),
I think this is the best choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
