ZENOTME commented on PR #2650: URL: https://github.com/apache/avro/pull/2650#issuecomment-1880353697
> @ZENOTME I think this PR is good to go! Please let me know if you have any concerns! Sorry for being late. Thanks for your help! > I have the feeling that the way I ignored logicalType to be stored in the custom attributes would break your expectations about Fixed+uuid. But I wonder whether keeping the logicalType as a custom attribute is good in general. Yes, ignored logicalType here may couse unexpectation behaviour. I think keeping keeping the logicalType as a custom attribute is reasonable behaviour because it let the user customiaze their own logical type even it's not supported by RustSDK. I guess the behaviour we ignore `logicalType` or other field here is to avoid duplication. So should we only ignore the `logicalType` when the schema in record field used it? e.g Uuid, Date, TimeMills,... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
